-
Notifications
You must be signed in to change notification settings - Fork 61.9k
Update evaluate-expressions-in-workflows-and-actions.md #38230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Explained how operators are used. issue-github#37006
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
@silky-x0 Thanks for opening a PR to address this issue! I'll get it triaged for review. |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
@TRIXMI could you please provide more info what you trying to say? |
@silky-x0 It's spam, probably a bot. We get a lot of them in here. Don't worry about it, I blocked it. If we start seeing more, I'll lock the conversation. Sometimes for whatever reason they all just pile into one specific issue or PR. |
@Sharra-writes okey, does it usually take this long to close PR related to DOCS? |
@silky-x0 We're a small team and for something that needs both an SME and writer review (as this does and will), I'm afraid I'm going to be thanking you for your patience a lot. 😅 I will keep you updated as we make our way through the review process, though. And just to get it started, I do appreciate your patience. 💛 |
@Sharra-writes no worries, patience is key. |
@silky-x0 Okay, so, here's what's going on: I got a review from one writer who wanted to keep just the change to line 112, without adding in the example you wrote. He recommended a review from another writer to confirm, but that writer has been swamped, so I haven't been able to get him to take a look. So. We have a review from one writer, which is technically enough. Either we can go with his suggestion and get rid of the example, or I can wait to confirm with the other writer whenever he has time, and see if he has a different answer. |
@Sharra-writes I guess what he said will suffice because most the people coming here would obviously know how OR, AND works. I'll make changes then. |
Removed Unnecessary explanations
@Sharra-writes Everything's done I've removed those lines. |
@silky-x0 Beautiful. Thank you again for being patient with us, and I'll get this merged as soon as checks are passing! |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Explained how operators are used.
issue-#37006
Why:
Which operator is a ternary exactly? #37006
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: